Ran the tests. This fixes it. It was probably Feb with 28 days that threw us off...

bors r+

Build failed:

• ci/semaphoreci/push: Integration Tests

bors try

try

Build failed:

• ci/semaphoreci/push: Integration Tests

I tried running the tests on my laptop. The integration tests passed, but I see a failure in the Stock integration test:

The end-to-end tests passed. So the only test that failed is the "Stock Integration" test.

I tried running the tests on my laptop. The integration tests passed, but I see a failure in the Stock integration test

I wonder if this is because April only has 30 days?

When I look at the failure, I see (in depot.js:106) that the expected values are:
values = {
algo_def : 33.27,
algo_msh : 33.15,
sum_days : 365,
sum_stock_day : 275,
sum_consumption_day : 8,
sum_consumed_quantity : 300,
number_of_month : 12,
sum_stock_out_days : 90,
head_days : 0,
};
But the actual values (from res.body) are:
algo_def : 33.15,
algo_msh : 33.93,
sum_days : 365,
sum_stock_day : 276,
sum_consumption_day : 8,
sum_consumed_quantity : 300,
number_of_month : 12,
sum_stock_out_days : 89,
head_days : 0,

When I checked the CMM calculations they are correct based on the difference in the value of 'sum_stock_out_days'. So I think this is the key to the problem.

I was able to git this test working by converting the calculations of expiration dates based on DAY's (not MONTH's) in the stock SQL and updating the depot test file. I modified these files (renamed, attached)
modified: test/data/service-stock.sql
modified: test/integration-stock/depots.js
service-stock.sql.txt
depots.js.txt

@jniles and @mbayopanda : Please try these files and see if they work on your system. If so, this seems like the correct approach since it guarantees the same number of days for the tests/expirations/etc regardless of whether months have different numbers of days. However I think I may something may need further fixing because the "head_days" changed from 0 to 29 for the tests.

I tried running the tests on my laptop. The integration tests passed, but I see a failure in the Stock integration test:

The end-to-end tests passed. So the only test that failed is the "Stock Integration" test.

@jmcameron what is your environment configuration (MySQL version, Node version, OS) because the integration tests passed on my configuration (MySQL 5.7 and 8, Node 16.0.0, Windows 10.

You're right Sir, the Stock Integration Tests failed on both MySQL 5.7 and 8, the good news is that the updates you made fix the tests. Thank you 👍🏽

I was able to git this test working by converting the calculations of expiration dates based on DAY's (not MONTH's) in the stock SQL and updating the depot test file. I modified these files (renamed, attached)
modified: test/data/service-stock.sql
modified: test/integration-stock/depots.js
service-stock.sql.txt
depots.js.txt

@jniles and @mbayopanda : Please try these files and see if they work on your system. If so, this seems like the correct approach since it guarantees the same number of days for the tests/expirations/etc regardless of whether months have different numbers of days. However I think I may something may need further fixing because the "head_days" changed from 0 to 29 for the tests.

The tests works correctly now on my machine 👍🏽

Build succeeded:

• ci/semaphoreci/push: Integration Tests